On 18.04.2012 12:23, Wolfgang Denk wrote:
Dear "Timo Ketola",
In message1334735852-23415-2-git-send-email-timo@exertus.fi you wrote:
Defining CONFIG_FSL_ESDHC brings in a call to get_clocks, so let's implement get_clocks function. This is how it seems to be implemented elsewhere. ...
...
I understand this is a (eventually modified ?) reposting of patches you posted before.
Yes
in this case it is mandatory not only to mark this in the Subject,
Ok, how to do that I learned just now.
but also to provide a detailled change log (below the "---" line); see http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
I tried to provide that in the 0/x message but do you mean that I should provide it separately for every single patch? I see that your reference asks just that.
I was in impression that 'git send-email' (alone) would do the right thing but it doesn't give me opportunity to edit actual patch messages, only the cover letter. And I saw many examples of people putting the log in the cover letter. So how do people do that? 'git format-patch' then manually edit patch files, then send them with 'git send-email'?
I'm not going to try to find out which review comments you have included, and what you changed to do so; sorry, but I don;t have that much time.
So do I have to reference review comments somehow?
Please consider the whole patch series ignored.
Ok
--
Timo