Hi
On 03/03/2018 02:59 AM, Álvaro Fernández Rojas wrote:
Move dma_ops to a separate header file, following other uclass implementations. While doing so, this patch also improves dma_ops documentation.
Signed-off-by: Álvaro Fernández Rojas noltari@gmail.com Reviewed-by: Simon Glass sjg@chromium.org
v4: no changes v3: Introduce changes reported by Simon Glass:
- Improve dma-uclass.h documentation.
- Switch to live tree API.
drivers/dma/dma-uclass.c | 3 ++- include/dma-uclass.h | 39 +++++++++++++++++++++++++++++++++++++++ include/dma.h | 22 ---------------------- 3 files changed, 41 insertions(+), 23 deletions(-) create mode 100644 include/dma-uclass.h
I've sent the same comment for prev patch version also.
this patch will break build of existing DMA drivers, as the do not have #include <dma-uclass.h>.
drivers/dma/ti-edma3.c:563:21: error: variable 'ti_edma3_ops' has initializer but incomplete type static const struct dma_ops ti_edma3_ops = { ^~~~~~~ drivers/dma/ti-edma3.c:564:2: error: unknown field 'transfer' specified in initializer .transfer = ti_edma3_transfer, ^ drivers/dma/ti-edma3.c:564:14: warning: excess elements in struct initializer .transfer = ti_edma3_transfer, ^~~~~~~~~~~~~~~~~ drivers/dma/ti-edma3.c:564:14: note: (near initialization for 'ti_edma3_ops') drivers/dma/ti-edma3.c:563:29: error: storage size of 'ti_edma3_ops' isn't known static const struct dma_ops ti_edma3_ops = { ^~~~~~~~~~~~ make[1]: *** [drivers/dma/ti-edma3.o] Error 1