Hi Marek,
On 2015年12月24日 11:02, Marek Vasut wrote:
On Thursday, December 24, 2015 at 03:50:57 AM, Thomas Chou wrote:
Hi Marek,
On 2015年12月24日 09:29, Marek Vasut wrote:
On Thursday, December 24, 2015 at 01:51:23 AM, Thomas Chou wrote:
Show sector erase progress with dot and comma.
Signed-off-by: Thomas Chou thomas@wytron.com.tw
Shouldn't this go into common code ?
The code to print a dot is minimal. It will cost more if this go into common code.
But then this driver behaves in a non-standard manner AND noone benefits from this functionality but this driver.
The sector erase might take very long when there are a lot of sectors to erase, say 12 min to 50 min for 1024 sectors on the 10m50 board. Without the display of progress, it will look like the board hangs.
The dotting code comes from the old cfi_flash.c. Some other parallel flash have this, but not spi-flash. It is trivial to add though.
Best regards, Thomas