Dear "Hiremath, Vaibhav",
In message 19F8576C6E063C45BE387C64729E739404370D7ACC@dbde02.ent.ti.com you wrote:
...
+#ifndef __ASSEMBLY__ +extern struct gpmc *gpmc_cfg; +extern unsigned int boot_flash_base; +extern volatile unsigned int boot_flash_env_addr; +extern unsigned int boot_flash_off; +extern unsigned int boot_flash_sec; +extern unsigned int boot_flash_type; +#endif
Please add prototype declarations to some appropriate header file instead.
[Hiremath, Vaibhav] Actually this code is borrowed from OMAP3EVM file, and I think almost all devices handles this same way.
Yes, this escaped us before - but now we got aware of this problem we don't want to add more of this (and clean up the existing code ASAP).
It is bit difficult to handle this, since we are supporting multiple flash devices and these variables are initialized run-time and so the macros below,
CONFIG_SYS_FLASH_BASE, CONFIG_ENV_OFFSET, CONFIG_SYS_ENV_SECT_SIZE
Um... I cannot parse this senstence. Some words seem to be missing?
I will try to dig bit more on this, but I think as of now we can go with this.
Sorry, I disagree.
Best regards,
Wolfgang Denk