Re: [U-Boot] [PATCH] Followup fixes on the mtdparts spread patchset

10 Sep 2010


      Hi Wolfgang,
On Fri, Sep 10, 2010 at 1:32 PM, Wolfgang Denk wd@denx.de wrote:
...
Dear Ben Gardiner,
In message AANLkTi=8oQgMy2+_tbLHgrYRoDP8MUBneB8jxjsFTtN6@mail.gmail.com you wrote:
...
It's fine by me but I'm curious: why move the declaration of the stack
variables i and net_size to before the check of the block_isbad
function pointer? Before this change, I think there would be no
allocation of these variables on the stack if the block_isbad function
pointer is null.
The optimizer is more clever than you assume.
I see -- I'll start giving it the benefit of the doubt then :)
Best Regards,
Ben Gardiner
---
Nanometrics Inc.
http://www.nanometrics.ca