
Dear Guennadi Liakhovetski,
In message Pine.LNX.4.64.0808271746001.6718@axis700.grange you wrote:
Your
Subject: Re: [U-Boot] [PATCH 2/6] Separate flash read and write operations
does not make a good commit comment - you should at least add "fw_env:" or similar so eveybody know which "flash read and write operations" you are talking about.
The flash_io function was used for both read and write operations, whereby very little code was shared between the two modes. By breaking this function we simplify the code and save one level of identation.
If I see this correctly, you did not implement any functional changes or bug fixes, i. e. it was just a code restructuring because you didn't like the current style and preferred another one?
Best regards,
Wolfgang Denk