Re: [U-Boot] [ANN] U-Boot v2015.10-rc4 released

Dear Fabio,

In message CAOMZO5ATtUjk_TVS94N6evTKndozVRH9nXyE0UHPJ3sCQ906Zg@mail.gmail.com you wrote:

Ok, the issue is due to endianness: on LS1021 the watchdog is big-endian, so that's why we can't use clrsetbits_le16().

...

•   int reg;
  
  

•   clrsetbits_le16(&wdog->wcr, 0, WCR_WDE);
  

•   reg = readw(&wdog->wcr);
  

•   reg |= WCR_WDE;
  

•   writew(reg, &wdog->wcr);
  

But this is broken. We have the clrsetbits() [*] macros exactly to avoid such code.

[*] resp. setbits() - using clrsetbits*() with 0 as clear mask is a stupid thing to do anyway.

Best regards,

Wolfgang Denk