Dear Stephen,
In message 571E75E2.6020008@wwwdotorg.org you wrote:
/*
- (C) Copyright 2013
- Avionic Design GmbH <www.avionic-design.de>
- Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved.
- SPDX-License-Identifier: GPL-2.0+
*/
#include <common.h> #include <dm.h>
+#include <i2c.h> +#include <asm/gpio.h> #include <asm/arch/pinmux.h> #include <asm/arch/gp_padctrl.h> #include <asm/arch/gpio.h> -#include <asm/gpio.h> #include "pinmux-config-tamonten-ng.h" -#include <i2c.h>
#define PMU_I2C_ADDRESS 0x2D
Do you really think that moving around two lines of code is a big enough creative achievement to justify adding a copyright note on it?
My understanding is yes; I edited the file in a non-trival way and so NVIDIA's copyright applies to those portions. I'd consider whitespace or spelling fixes to be trivial, but not much else. I believe there is creative achievement in cleaning up the code-base this way.
Well, do you _really_ mean that moving two ines of code a few lines up is a non-trivial change? Sorry, but I strongly disagree here.
This is not any change where you can claim any copyright for.
FWIW, the purpose is to create a cleaner separate between the core Tegra SoC support code and board/driver code, to reduce their current rather tight coupling. The copyright changes are just correct application of the process of editing files; something I admit we/I've been a bit lax about in the past.
s/correct/aggressive/
This seems not fair to me, and I would like to ask you to rework this whole patch set and be a little less aggressive in copyright claims.
I don't see what's unfair either way. As far as I'm concerned, the copyright notices are simply due to my following the process I must follow. I don't believe the presence of NVIDIA's copyright notices takes anything away from anyone else, and as I mentioned above, they seem valid to me.
Well, if I read the code before and after your changes, I see a lot of places where new copyright notes appear in prominent places, and some old ones are gone, or are now just an also-ran.
I do not think that this is your intention, but it is how this appears to me, and I really dislike it. It expresses an attitude I dislike.
Best regards,
Wolfgang Denk