On Saturday, November 14, 2015 at 03:05:37 AM, Simon Glass wrote:
Hi,
On 13 November 2015 at 11:10, Alexey Brodkin
Alexey.Brodkin@synopsys.com wrote:
Similarly to Linux kernel it's nice to have generic driver for EHCI-compatible host controllers.
This implementation is very minimalistic and doesn't have any platform-specific glue code nor phy-related operations.
For example this allows usage of USB-storage devices with Synopsys DesignWare AXS10x boards.
Signed-off-by: Alexey Brodkin abrodkin@synopsys.com Cc: Stephen Warren swarren@nvidia.com Cc: Simon Glass sjg@chromium.org Cc: Marek Vasut marex@denx.de
drivers/usb/host/Kconfig | 7 +++++ drivers/usb/host/Makefile | 1 + drivers/usb/host/ehci-generic.c | 57 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 65 insertions(+) create mode 100644 drivers/usb/host/ehci-generic.c
Reviewed-by: Simon Glass sjg@chromium.org
Please see nits below.
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 2a2bffe..a500578 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -73,4 +73,11 @@ config USB_EHCI_UNIPHIER
---help--- Enables support for the on-chip EHCI controller on UniPhier SoCs.+config USB_EHCI_GENERIC
bool "Support for generic EHCI USB controller"depends on OF_CONTROLdefault y---help---Enables support for generic EHCI controller.such as Synopsys ...
Please don't add "such as FOO", it's confusing.
what does 'generic' mean? Please add a few more details.
Otherwise, I agree with the rest.
Thanks!