Re: [U-Boot] [PATCH] cfi_flash: flinfo: allow user interrupt in flash print info fn

Dear Kim Phillips,

In message 20100726183539.1732824f.kim.phillips@freescale.com you wrote:

flashes getting larger, users more impatient.

Signed-off-by: Kim Phillips kim.phillips@freescale.com

drivers/mtd/cfi_flash.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c index 3267c5d..38d0ca5 100644 --- a/drivers/mtd/cfi_flash.c +++ b/drivers/mtd/cfi_flash.c @@ -1159,6 +1159,8 @@ void flash_print_info (flash_info_t * info)

puts ("\n Sector Start Addresses:"); for (i = 0; i < info->sector_count; ++i) {

• if (ctrlc())
  

• 	return;
  

  if ((i % 5) == 0) printf ("\n");

#ifdef CONFIG_SYS_FLASH_EMPTY_INFO

NAK. This code (and the existing "if ((i % 5) == 0) printf ("\n");" as well) is incorrectly placed, i. e. before variable declarations.

Please fix.

Best regards,

Wolfgang Denk