Hi Simon,
On 10/30/2015 01:16 AM, Simon Glass wrote:
Hi Thomas,
On 22 October 2015 at 07:25, Thomas Chou thomas@wytron.com.tw wrote:
Add a sandbox timer which get time from host os and a basic test.
Signed-off-by: Thomas Chou thomas@wytron.com.tw
arch/sandbox/dts/sandbox.dts | 4 ++ board/sandbox/sandbox.c | 2 + common/board_f.c | 2 +- configs/sandbox_defconfig | 2 + doc/device-tree-bindings/timer/sandbox_timer.txt | 7 ++++ drivers/timer/Kconfig | 7 ++++ drivers/timer/Makefile | 1 + drivers/timer/sandbox_timer.c | 53 ++++++++++++++++++++++++ include/configs/sandbox.h | 2 + test/dm/Makefile | 1 + test/dm/timer.c | 27 ++++++++++++
Can you please split out the board_f.c change into a separate commit?
But the sandbox will fail (with seg fault or hang) without the change in board_f.c . Is this alright?
+static const struct udevice_id sandbox_timer_ids[] = {
{ .compatible = "sandbox,timer", },You can drop the penultimate comma.
OK.
Thanks a lot for your review.
Best regards, Thomas