On Dec 1, 2010, at 10:06 AM, Haiying Wang wrote:
On Wed, 2010-12-01 at 08:56 -0700, Kumar Gala wrote:
diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init.c
b/arch/powerpc/cpu/mpc85xx/cpu_init.c
index 4b8faa5..eb34378 100644 --- a/arch/powerpc/cpu/mpc85xx/cpu_init.c +++ b/arch/powerpc/cpu/mpc85xx/cpu_init.c @@ -369,7 +369,7 @@ int cpu_init_r(void)
enable_cpc();-#ifdef CONFIG_QE +#if defined(CONFIG_QE) && !defined(CONFIG_SYS_QE_FW_IN_NAND) uint qe_base = CONFIG_SYS_IMMR + 0x00080000; /* QE immr base
*/
qe_init(qe_base); qe_reset();-- 1.7.3.1.50.g1e633
Any reason to just not move QE init for everyone?
That was based on Wolfgang's comment: http://lists.denx.de/pipermail/u-boot/2010-August/075657.html
Haiying
I think wolfgang's gripe is about putting the code into generic board_init_r().
I think we could move it so its in misc_init_r.
- k