On 22/09/10 14:43, Ben Gardiner wrote:
On Wed, Sep 22, 2010 at 9:16 AM, Nick Thompson nick.thompson@ge.com wrote:
Fixes build breakage in da830evm after commit 97003756249bd790910417eb66f0039bbf06a02c "da8xx: fixup ARM relocation support"
The da8xx fixup commit changed da830/da850 common code to make relocation work in da850, but didn't add the required defines to da830evm_config.h resulting in build failure in the common code.
This patch adds those defines for da830, but makes no sense without also referring to the commit mentioned above.
Signed-off-by: Nick Thompson nick.thompson@ge.com
Sorry that was my fault for not adding the needed changes to the da830 config also when I submitted that patch.
It's not a problem - at least you laid the ground work for a fix that had to be done anyway. I only mentioned it to put the patch in context.
What about removing "#define CONFIG_SKIP_RELOCATE_UBOOT" as in commit ab86f72c354f9b2572340f72b74ca0a258c451bd ?
Hmmm. It wouldn't hurt I guess. The UBL copies the code to the correct address though doesn't it? The copy is not executed and so the code is redundant - or did I miss something?
Nick.