Hi Bin,
On Mon, 2018-10-22 at 15:22 +0800, Bin Meng wrote:
Hi Lukas,
On Sat, Oct 20, 2018 at 6:10 AM Lukas Auer lukas.auer@aisec.fraunhofer.de wrote:
Move the target selection into a separate file (Kconfig.board) to avoid clutter once we support more boards.
Signed-off-by: Lukas Auer lukas.auer@aisec.fraunhofer.de
arch/riscv/Kconfig | 17 ++--------------- arch/riscv/Kconfig.board | 14 ++++++++++++++ 2 files changed, 16 insertions(+), 15 deletions(-) create mode 100644 arch/riscv/Kconfig.board
diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index ce07fb4b55..10d17a0e18 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -4,21 +4,6 @@ menu "RISC-V architecture" config SYS_ARCH default "riscv"
-choice
prompt "Target select"optional-config TARGET_AX25_AE350
bool "Support ax25-ae350"-config TARGET_QEMU_VIRT
bool "Support QEMU Virt Board"-endchoice
-source "board/AndesTech/ax25-ae350/Kconfig" -source "board/emulation/qemu-riscv/Kconfig"
choice prompt "Base ISA" default ARCH_RV32I @@ -72,4 +57,6 @@ config 32BIT config 64BIT bool
+source "arch/riscv/Kconfig.board"
I am OK with moving board one to a separate file, though it looks no other arch uses scuh convention in U-Boot :)
However, with this change, it lost the capability of overriding an architecture defined Kconfig option at board level.
I have a patch @
http://git.denx.de/?p=u-boot/u-boot-x86.git;a=commitdiff;h=5a650689410482907...
to express such capability.
This should be easy to fix by just moving the source statement, right?
Thanks, Lukas
endmenu diff --git a/arch/riscv/Kconfig.board b/arch/riscv/Kconfig.board new file mode 100644 index 0000000000..fcada760c8 --- /dev/null +++ b/arch/riscv/Kconfig.board @@ -0,0 +1,14 @@ +choice
prompt "Target select"optional+config TARGET_AX25_AE350
bool "Support ax25-ae350"+config TARGET_QEMU_VIRT
bool "Support QEMU Virt Board"+endchoice
+source "board/AndesTech/ax25-ae350/Kconfig"
+source "board/emulation/qemu-riscv/Kconfig"
Regards, Bin