On 9/22/22 13:27, Simon Glass wrote:
Hi,
[...]
It's similar, yes. I think the biggest hang-up for me is that while the Kconfig help text isn't the best documentation for what is needed when adding SPL to a board, it's better than code-only comments. I know Simon asked for a comment on the weak function, but how about starting doc/develop/spl.rst and make at least this new content kernel-doc format so it can be included there?
Yes, well you know my feelings on weak functions and how hard they make it to figure out what code is actually running. I actually like you if(...) idea along with better docs, since the Kconfig option is at least a positive signal that the function is used.
Hum, all right, the increase in size and the lower than expected dislike for ifdeffery means we should drop this patch.