Re: [U-Boot] [PATCH] imx: Add support for the SabreSD shipped with i.MX6DL

Dear Pierre Aubert,

In message 1366296086-22394-1-git-send-email-p.aubert@staubli.com you wrote:

The SabreSD platform is available with i.MX6Q or i.MX6DL. This patch adds the support of the i.MX6DL. The config file and the board directory are renamed to remove the reference to the MX6Q.

Formal issues:

- entry to MAINTAINERS file missing - there are 2 checkpatch warnings ("please, no spaces at the start of a line") that need to be fixed.

int checkboard(void) {

• puts("Board: MX6Q-SabreSD\n");

+#ifdef CONFIG_MX6Q

• puts("Board: MX6Q-SabreSD\n");

+#else

• puts("Board: MX6DL-SabreSD\n");

+#endif

Can we please avoid such #ifdef's? Here, we could for example refer to the board name (CONFIG_SYS_BOARD if you like the name, or some custom defined CONFIG_BOARD_NAME like other boards do).

Best regards,

Wolfgang Denk