Hi Stefano,
On Saturday, November 10, 2012 8:42:24 AM, Stefano Babic wrote:
On 08/11/2012 21:27, Benoît Thébaudeau wrote:
The EHCI definitions in i.MX31's imx-regs.h are MXC-generic, so move them to ehci-fsl.h so that all MXC SoCs can use them.
Signed-off-by: Benoît Thébaudeau benoit.thebaudeau@advansee.com Cc: Marek Vasut marex@denx.de Cc: Stefano Babic sbabic@denx.de
Hi Benoît,
Changes for v2: None.
.../arch/arm/include/asm/arch-mx31/imx-regs.h | 26
.../include/usb/ehci-fsl.h | 22 +++++++++++++++++ 2 files changed, 22 insertions(+), 26 deletions(-)
By applying this patchset I see several minor issues reported by checkpatch:
WARNING: line over 80 characters #303: FILE: drivers/usb/host/ehci-mx5.c:43: +#define MXC_OTG_UCTRL_OWIE_BIT (1 << 27) /* OTG wakeup intr enable */
WARNING: line over 80 characters #305: FILE: drivers/usb/host/ehci-mx5.c:45: +#define MXC_H1_UCTRL_H1UIE_BIT (1 << 12) /* Host1 ULPI interrupt enable */
WARNING: line over 80 characters #306: FILE: drivers/usb/host/ehci-mx5.c:46: +#define MXC_H1_UCTRL_H1WIE_BIT (1 << 11) /* HOST1 wakeup intr enable */
WARNING: line over 80 characters #312: FILE: drivers/usb/host/ehci-mx5.c:50: +#define MXC_OTG_PHYCTRL_OC_DIS_BIT (1 << 8) /* OTG Disable Overcurrent Event */
WARNING: line over 80 characters #313: FILE: drivers/usb/host/ehci-mx5.c:51: +#define MXC_H1_OC_DIS_BIT (1 << 5) /* UH1 Disable Overcurrent Event */
WARNING: line over 80 characters #343: FILE: drivers/usb/host/ehci-mx5.c:174:
v &= ~MXC_H1_UCTRL_H1PM_BIT; /* HOST1 power mask unused */WARNING: line over 80 characters #352: FILE: drivers/usb/host/ehci-mx5.c:190:
v &= ~MXC_H2_UCTRL_H2PM_BIT; /* HOST2 power mask unused */WARNING: line over 80 characters #641: FILE: drivers/usb/host/ehci-mx5.c:47: +#define MXC_OTG_UCTRL_O_PWR_POL_BIT (1 << 24) /* OTG power pin polarity */
WARNING: line over 80 characters #645: FILE: drivers/usb/host/ehci-mx5.c:51: +#define MXC_H1_UCTRL_H1_PWR_POL_BIT (1 << 8) /* HOST1 power pin polarity */
WARNING: line over 80 characters #648: FILE: drivers/usb/host/ehci-mx5.c:54: +#define MXC_OTG_PHYCTRL_OC_POL_BIT (1 << 9) /* OTG Polarity of Overcurrent */
WARNING: line over 80 characters #650: FILE: drivers/usb/host/ehci-mx5.c:56: +#define MXC_H1_OC_POL_BIT (1 << 6) /* UH1 Polarity of Overcurrent */
WARNING: line over 80 characters #652: FILE: drivers/usb/host/ehci-mx5.c:58: +#define MXC_OTG_PHYCTRL_PWR_POL_BIT (1 << 3) /* OTG Power Pin Polarity */
WARNING: line over 80 characters #873: FILE: drivers/usb/host/ehci-mxc.c:85:
MX25_H1_OCPOL_BIT | MX25_H1_TLL_BIT | MX25_H1_USBTE_BIT |WARNING: line over 80 characters #1078: FILE: drivers/usb/host/ehci-mxc.c:184:
MX35_H1_OCPOL_BIT | MX35_H1_TLL_BIT | MX35_H1_USBTE_BIT |WARNING: line over 80 characters #1179: FILE: board/freescale/mx35pdk/mx35pdk.c:105:
- mxc_request_iomux(MX35_PIN_USBOTG_PWR, MUX_CONFIG_SION |
MUX_CONFIG_FUNC);
WARNING: line over 80 characters #1180: FILE: board/freescale/mx35pdk/mx35pdk.c:106:
- mxc_request_iomux(MX35_PIN_USBOTG_OC, MUX_CONFIG_SION |
MUX_CONFIG_FUNC);
total: 0 errors, 16 warnings, 810 lines checked
Can you fix them ? Thanks !
OK, I'll do that. For the #define-s, do you prefer that I move the comment to the previous line, or that I split the end of the comment to the next line?
Best regards, Benoît