Hi Przemyslaw,
On 9 September 2014 04:26, Przemyslaw Marczak p.marczak@samsung.com wrote:
Hello Simon,
On 07/23/2014 02:11 PM, Simon Glass wrote:
Change this board to use the exynos common config and add a device tree.
This also adds a pinmux header file - but it is just a copy of the exynos one so may be incorrect.
Signed-off-by: Simon Glass sjg@chromium.org
arch/arm/dts/Makefile | 1 + arch/arm/dts/s5pc1xx-goni.dts | 21 ++++++++++ arch/arm/include/asm/arch-s5pc1xx/periph.h | 61 ++++++++++++++++++++++++++++++ arch/arm/include/asm/arch-s5pc1xx/pinmux.h | 50 ++++++++++++++++++++++++ drivers/mmc/s5p_sdhci.c | 2 - include/configs/s5p_goni.h | 55 +++++---------------------- 6 files changed, 143 insertions(+), 47 deletions(-) create mode 100644 arch/arm/dts/s5pc1xx-goni.dts create mode 100644 arch/arm/include/asm/arch-s5pc1xx/periph.h create mode 100644 arch/arm/include/asm/arch-s5pc1xx/pinmux.h
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index 3b760ff..6a6e664 100644 --- a/arch/arm/dts/Makefile +++ b/arch/arm/dts/Makefile @@ -1,3 +1,4 @@ +dtb-$(CONFIG_S5PC110) += s5pc1xx-goni.dtb dtb-$(CONFIG_EXYNOS4) += exynos4210-origen.dtb \ exynos4210-smdkv310.dtb \ exynos4210-universal_c210.dtb \ diff --git a/arch/arm/dts/s5pc1xx-goni.dts b/arch/arm/dts/s5pc1xx-goni. dts new file mode 100644 index 0000000..c390c8f --- /dev/null +++ b/arch/arm/dts/s5pc1xx-goni.dts @@ -0,0 +1,21 @@ +/*
- Samsung's Exynos4210-based SMDKV310 board device tree source
- Copyright (c) 2014 Google, Inc
- SPDX-License-Identifier: GPL-2.0+
- */
+/dts-v1/;
This is a mistake. Exynos4 is different than s5pc1xx(which was later called exynos3 and is also called s5pv210(kernel)). So the s5pc1xx-goni.dts should include: model = "Samsung Goni based on S5PC110"; compatible = "samsung,goni", "samsung,s5pc110";
Thanks for the review.
And the base addresses are different than exynos4. Please look at: arch/arm/include/asm/arch-s5pc1xx/cpu.h
OK
This will require also a common file for s5pc1xx: s5pc1xx-common.dts. Moreover, the S5PC100 and S5PC110 have lot of differences.
Simon, I think that this is a job for goni's maintainer, since you can't test it on a hardware.
Yes that would be great. To be clear, my intent is to make all these boards similar so that it is possible to change over the GPIO and serial drivers to use driver model.
Robert, can you look at this?
+/include/ "exynos4.dtsi"
+/ {
model = "Samsung SMDKV310 on Exynos4210";compatible = "samsung,smdkv310", "samsung,exynos4210";aliases {serial0 = "/serial@13800000";console = "/serial@13820000";};+};
Best regards,
Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak@samsung.com
Regards, Simon