Dear Remy,
In message 3efb10970812090013o2f7dcb3ck6a0e3f9bcf4a4add@mail.gmail.com you wrote:
...but your new code has new issues, too.
Nothing is perfect... Making this code perfect would require a complete rewrite... ;-)
;-)
The (original) code is buggy too, because I have discovered a strange bug which is causing me quite some headaches last week... ;-)
Maybe - but please let's be strict and keep reformatting, code reorganization and bug fixing all separate.
At least formatting/whitespaces/tabs is better now. Long indentations and similar code has been moved into separate routines and so on.
This is code reorganization, not mere reformatting.
...looks like a massive code change, not only a coding style cleanup.
No, I just reordered a strange construction, by moved a piece of code that could only be reached by goto to a label to the place where the goto was listed. This made the code more readable. To me this is still just coding style.
Ok, then let's use clear terminology.
Please submit as two separate patches.
There are a few little things that could be put into a separate patch.
Please split such that reformatting is separate from code reorganization, and any code changes/bug fixes is a third (group of) patch(es).
I will see what I can do...
Thanks.
Best regards,
Wolfgang Denk