8 Jul
2011
8 Jul
'11
11:17 a.m.
Dear Daniel Schwierzeck,
In message 1309883182-12854-4-git-send-email-daniel.schwierzeck@googlemail.com you wrote: ...
+# create 'spl/obj' within OBJTREE for spl +OBJTREE := $(OBJTREE)/spl/obj +LNDIR := $(OBJTREE)
+include $(TOPDIR)/config.mk +# We want the final binaries in this directory +obj := $(obj)../ +START = $(OBJTREE)/$(CPUDIR)/start.o
I don't really like these "../" parts. Can we please try to omit these? We can use $(TOPDIR) and/or $(OBJTREE) instead to express the path names, can't we?
I have to admit that I don't understand what the old and the new values of $(obj) are above...
[The same applies to the "CPPFLAGS += -I$(OBJTREE)/../../include2 -I$(OBJTREE)/../../include" part in the first patch.]
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Lady Nancy Astor:
"Winston, if you were my husband, I'd put poison in your coffee."
Winston Churchill:
"Nancy, if you were my wife, I'd drink it."