Hi Heinrich,
On Fri, 31 Mar 2023 at 10:53, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
Am 30. März 2023 23:32:27 MESZ schrieb Simon Glass sjg@chromium.org:
U-Boot sets up the ACPI tables during startup. Rather than creating a new set, install the existing ones. Create a memory-map record to cover the tables.
I understand that this works on QEMU which provides ACPI tables. But on all other systems that use ACPI you will still have to generate ACPI tables.
So you cannot simply drop the table generation.
If you have moved the generation step somewhere else, this patch should mention the new location.
This only applies to x86 as we don't have ACPI tables for other archs. The generation step has not moved, it's just that they have always been generated before start-up. I think this might have been overlooked when writing the UEFI code? I'm actually not sure how this worked before on any x86 board.
See last_stage_init() which calls write_tables().
Regards, Simon
Signed-off-by: Simon Glass sjg@chromium.org
lib/efi_loader/efi_acpi.c | 33 +++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 14 deletions(-)
[..]