Dear Sjoerd Simons,
On 28/11/14 00:08, Sjoerd Simons wrote:
Not all exynos 5420 based devices with an LCD also have a parade LVDS bridge. So make sure compilation doesn't break if CONFIG_LCD is enabled and CONFIG_VIDEO_PARADE is not.
Signed-off-by: Sjoerd Simons sjoerd.simons@collabora.co.uk
Changes since V1: New patch
arch/arm/include/asm/arch-exynos/system.h | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/arm/include/asm/arch-exynos/system.h b/arch/arm/include/asm/arch-exynos/system.h index 320763f..dd68290 100644 --- a/arch/arm/include/asm/arch-exynos/system.h +++ b/arch/arm/include/asm/arch-exynos/system.h @@ -42,6 +42,10 @@ void set_system_display_ctrl(void); int exynos_lcd_early_init(const void *blob);
/* Initialize the Parade dP<->LVDS bridge if present */ +#ifdef CONFIG_VIDEO_PARADE int parade_init(const void *blob); +#else +static inline int parade_init(const void *blob) { return -1; } +#endif
Actually, it does not related with this patch.. and I know that you are not an author. But.. I'd like ask you, why parade_init function is in exynos header file? If you are agreed, could you please make new header file? (e.g: include/parade.h)
And I think you missed removing the CONFIG_VIDEO_PARADE at peach-pi.h
Thanks, Minkyu Kang.