Re: [U-Boot] [PATCH 09/10] x86: Init the debug UART if enabled

Hi Simon,

On Wed, Sep 9, 2015 at 7:52 AM, Simon Glass sjg@chromium.org wrote:

If the debug UART is enabled, get it ready for use at the earliest possible opportunity. This is not actually very early, but until we have a stack it is difficult to make it work.

Signed-off-by: Simon Glass sjg@chromium.org

arch/x86/cpu/start.S | 3 +++ 1 file changed, 3 insertions(+)

diff --git a/arch/x86/cpu/start.S b/arch/x86/cpu/start.S index d072825..e6e9cb5 100644 --- a/arch/x86/cpu/start.S +++ b/arch/x86/cpu/start.S @@ -134,6 +134,9 @@ car_init_ret: * mov $'a', %eax * call printch */

Can we remove the comment block above since it is just duplicate to the codes below?

+#ifdef CONFIG_DEBUG_UART

•   call  debug_uart_init
  

nits: please use a 'tab' after 'call'.

+#endif

    /* Get address of global_data */
    mov     %fs:0, %edx

--

Regards, Bin