13 Mar
2009
13 Mar
'09
8:58 a.m.
OK, no problem. Eventually I'll get it right :-) 3rd (and hopefully final) attempt:
This patch makes sure the correct mask is applied when setting the encryption and I2C bus 0 clock in SCCR. Failing to do so may lead to ENCCM being 0 in which case I2C bus 0 won't function.
diff --git a/cpu/mpc83xx/cpu_init.c b/cpu/mpc83xx/cpu_init.c index 491c2e5..8e9c875 100644 --- a/cpu/mpc83xx/cpu_init.c +++ b/cpu/mpc83xx/cpu_init.c @@ -106,7 +106,7 @@ void cpu_init_f (volatile immap_t * im) #ifdef CONFIG_SYS_SCCR_ENCCM /* Encryption clock mode */ im->clk.sccr = (im->clk.sccr & ~SCCR_ENCCM) | - (CONFIG_SYS_SCCR_ENCCM << SCCR_PCICM_SHIFT); + (CONFIG_SYS_SCCR_ENCCM << SCCR_ENCCM_SHIFT); #endif
#ifdef CONFIG_SYS_SCCR_PCICM
--
1.5.2.2
Signed-off-by: Norbert van Bolhuis nvbolhuis@aimvalley.nl
Wolfgang Denk wrote:
> Dear Norbert van Bolhuis,
>
> In message 49B8B26B.4090104@aimvalley.nl you wrote:
>> Yes I just cut-n-pasted it.
>> I hope it's better now.
>
> No, it is not better.
>
> Patches should be sent inline, and not as attachments. It would be
> best if you used git-send-email to post the patch.
>
> Also, your Signed-off-by: line is missing in the patch.
>
> And it would be better if you used git-format-patch to create the
> patch.
>
>
> Sorry for the trouble for a one-line-fix, but I think it is important
> to learn these things right in the beginning - the less efforts will
> be there when it comes to real work.
>
> Best regards,
>
> Wolfgang Denk
>