
Hello.
Kumar Gala wrote:
If we are creating reference (handles) to nodes in a device tree we need to first create a new phandle in node and this needs a new phandle value. So we search through the whole dtb to find the max phandle value and return the next greater value for a new phandle allocation.
Signed-off-by: Kumar Gala galak@kernel.crashing.org
[...]
diff --git a/common/fdt_support.c b/common/fdt_support.c index 718b635..30c662a 100644 --- a/common/fdt_support.c +++ b/common/fdt_support.c @@ -1151,4 +1151,20 @@ int fdt_node_offset_by_compat_reg(void *blob, const char *compat, return -FDT_ERR_NOTFOUND; }
+/**
- fdt_alloc_phandle: Return next free phandle value
- @blob: ptr to device tree
- */
+int fdt_alloc_phandle(void *blob) +{
- int offset, len, phandle = 0;
- const u32 *val;
Shouldn't there be an emoty line after declarations?
for (offset = fdt_next_node(blob, -1, NULL); offset >= 0;
offset = fdt_next_node(blob, offset, NULL)) {
val = fdt_getprop(blob, offset, "linux,phandle", &len);
You indented the above 3 lines with spaces, other with tabs.
if (val) phandle = max(*val, phandle);
}
Another space-indented line...
WBR, Sergei