plagnioj@jcrosoft.com writes:
On 09:49 Fri 12 Oct , Markus Klotzbücher wrote:
Jean-Christophe,
Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com writes:
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com
drivers/Makefile | 11 ----------- drivers/usb/Makefile | 8 +++++++- drivers/{ => usb}/isp116x-hcd.c | 0
We had an discussion some time ago on how and where to put the different parts of the U-Boot USB stack. Basically we agreed to move all usb code to drivers/usb/ but furthermore we wanted to structure it in a similar way as the linux kernel does. Please see the following thread:
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/28154/focus=28177
Can restructure the drivers like this?
I've read the thread, and I agree with the conclusion and propose to merge the usb directory as follow
drivers/usb/host/
- generic and specific host controller drivers (ohci, uhci)
drivers/usb/core/
- usb core logic
drivers/usb/storage/
- storage class related code
drivers/usb/serial/
- e.g. serial support
drivers/usb/keyboard/
Please make this /drivers/usb/input . Who knows what U-Boot might support in future...
drivers/usb/gadget/
- usb gadget drivers
drivers/usb/misc/
- usb misc drivers
with the following nomenclature [type]-cpu.{h,c}
as example ohci-ppc4xx.c
I propose to begin with the drivers present in drivers and after merge the cpu drivers which an invasive work
Yes. Most cpu drivers (especially OHCI) should go away anyway and boards will use the generic drivers. Instead of moving this (pretty dead) code around, please help to port and test boards to/with the generic OHCI driver.
Viele Grüße / Best regards
Markus Klotzbücher
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de