Hi Bin,
On Tue, Nov 2, 2021 at 6:16 PM Bin Meng bmeng.cn@gmail.com wrote:
Hi Padmarao,
On Tue, Nov 2, 2021 at 7:03 PM Padmarao Begari padmarao.b@gmail.com wrote:
Hi Bin,
On Mon, Nov 1, 2021 at 2:15 PM Bin Meng bmeng.cn@gmail.com wrote:
On Fri, Oct 22, 2021 at 4:58 PM Padmarao Begari padmarao.begari@microchip.com wrote:
Update compatible as per Microchip PolarFire SoC ethernet device node.
Signed-off-by: Padmarao Begari padmarao.begari@microchip.com
drivers/net/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 8c6461e717..1b867bd5c2 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c @@ -1502,7 +1502,7 @@ static const struct udevice_id macb_eth_ids[] =
{
{ .compatible = "cdns,zynq-gem" }, { .compatible = "sifive,fu540-c000-gem", .data = (ulong)&sifive_config },
{ .compatible = "microchip,mpfs-mss-gem",
{ .compatible = "microchip,mpfs-gem",Could you please provide the upstream Linux kernel binding reference? I can't find such string in the Linux kernel.
We are not upstreamed Linux bindings yet, soon we will do.
The compatible "cdns,macb" is used in Linux for 32-bit and 64-bit DMA
transfer and U-Boot for 32-bit DMA transfer.
We added this string to support 64-bit DMA transfer of the GEM.
I suggest we upstream the new compatible string binding first, then update U-Boot. Otherwise U-Boot might be updated again if the compatible string is changed during the upstream review process.
We are going to use the same compatible strings in the U-Boot and Linux for PolarFire SoC peripherals like "microchip,mpfs-xxx" (xxx means peripheral name, ex. "microchip,mpfs-i2c", "microchip,mpfs-rtc"....etc). Here, we are updating compatible(existing) "microchip,mpfs-mss-gem" with "microchip,mpfs-gem".
Regards,
Bin