Re: [U-Boot-Users] [PATCH] USB Storage, add meaningful return value

Dear Aras,

in message 47E836F8.6090702@magtech.com.au you wrote:

This patch changes the "usb storage" command to return success iff it finds a USB storage device, otherwise it returns error.

Thanks. I appreciate your contribution, but please fix the coding style:

@@ -196,9 +196,13 @@ for (i = 0; i < usb_max_devs; i++) {

There is probably a { missing before this line (as this is not a single-line statement).

	printf ("  Device %d: ", i);
	dev_print(&usb_dev_desc[i]);

• 	return 0;
  

  } else
• {

...and then this should read

} else {

Thanks.

Best regards,

Wolfgang Denk