On Thursday 13 January 2011 12:48 AM, Albert ARIBAUD wrote: <snip ..>
- for (way = num_ways - 1; way>= 0 ; way--)
- for (set = num_sets - 1; set>= 0; set--) {
Please fix whitespacing around operators. The best way to ''catch'em all'' is to run Linux' checkpatch.pl (I do this with option --no-tree) on all patches that you submit to u-boot and, fix all warning and errors and if some are left that you think should not be fixed, mention them and explain why they're wrongly emitted.
I religiously do checkpatch whenever I send out a patch. Please note that my original mail seems to be fine. I saved it and ran checkpatch again. No errors, no warnings! Something amiss?
Well, something like "set>= 0" is quite surprising as it has inconsistent spacing around a binary operators. But you're right, checkpatch does not detect it. Can you fix them manually?
Checkpatch does find such issues. I was trying to say that my original mail doesn't have any spacing issues. The problem seems to have appeared in your reply. Is your mail client doing something funny?
Best regards, Aneesh
Amicalement,