Hi Lokesh,
Il 22/02/2021 07:08 Lokesh Vutla lokeshvutla@ti.com ha scritto:
Hi Dario,
On 13/02/21 4:30 pm, Dario Binacchi wrote:
Since the board has been converted to driver model and DT is supported, GPIO platform are no more required and can be removed.
Signed-off-by: Dario Binacchi dariobin@libero.it
Not all am335x platforms are converted to DT. Due to SPL size constraints am335x_evm_defconfig is still using plat data. This patch will break such platforms no?
I ran the commands: $ ./tools/buildman/buildman -o /tmp -P -E -W am33 $ grep -r 'OF_PLATDATA=y' /tmp/.bm-work/ | grep '.config' | wc -l 0
Is this enough to exclude the use of platform data by some configuration? I would think that am335x_evm_defconfig is not using platforma data. What am I doing wrong?
Thanks and regards, Dario
Thanks and regards, Lokesh
arch/arm/mach-omap2/am33xx/board.c | 23 ----------------------- 1 file changed, 23 deletions(-)
diff --git a/arch/arm/mach-omap2/am33xx/board.c b/arch/arm/mach-omap2/am33xx/board.c index e17898d8fb..f48d4cefc4 100644 --- a/arch/arm/mach-omap2/am33xx/board.c +++ b/arch/arm/mach-omap2/am33xx/board.c @@ -126,29 +126,6 @@ U_BOOT_DRVINFOS(am33xx_i2c) = { }; #endif
-#if CONFIG_IS_ENABLED(DM_GPIO) -static const struct omap_gpio_plat am33xx_gpio[] = {
- { 0, AM33XX_GPIO0_BASE },
- { 1, AM33XX_GPIO1_BASE },
- { 2, AM33XX_GPIO2_BASE },
- { 3, AM33XX_GPIO3_BASE },
-#ifdef CONFIG_AM43XX
- { 4, AM33XX_GPIO4_BASE },
- { 5, AM33XX_GPIO5_BASE },
-#endif -};
-U_BOOT_DRVINFOS(am33xx_gpios) = {
- { "gpio_omap", &am33xx_gpio[0] },
- { "gpio_omap", &am33xx_gpio[1] },
- { "gpio_omap", &am33xx_gpio[2] },
- { "gpio_omap", &am33xx_gpio[3] },
-#ifdef CONFIG_AM43XX
- { "gpio_omap", &am33xx_gpio[4] },
- { "gpio_omap", &am33xx_gpio[5] },
-#endif -}; -#endif #if CONFIG_IS_ENABLED(DM_SPI) && !CONFIG_IS_ENABLED(OF_CONTROL) static const struct omap3_spi_plat omap3_spi_pdata = { .regs = (struct mcspi *)AM33XX_SPI0_OFFSET,