Re: [PATCH v4 05/13] smbios: Add more properties

Hi Simon,

On Thu, Oct 22, 2020 at 10:20 PM Simon Glass sjg@chromium.org wrote:

The current tables only support a subset of the available fields defined by the SMBIOS spec. Add a few more.

Signed-off-by: Simon Glass sjg@chromium.org

(no changes since v1)

lib/smbios.c | 4 ++++ 1 file changed, 4 insertions(+)

diff --git a/lib/smbios.c b/lib/smbios.c index be72a98c49d..87dd4be415d 100644 --- a/lib/smbios.c +++ b/lib/smbios.c @@ -173,12 +173,15 @@ static int smbios_write_type1(ulong *current, int handle, ofnode node) CONFIG_SMBIOS_MANUFACTURER); t->product_name = smbios_add_prop_default(t->eos, node, "product", CONFIG_SMBIOS_PRODUCT_NAME);

•   t->version = smbios_add_prop(t->eos, node, "version");
  

How about:

t->version = smbios_add_prop_default(t->eos, node, "version", U_BOOT_VERSION_STRING);

    if (serial_str) {
            t->serial_number = smbios_add_string(t->eos, serial_str);
            strncpy((char *)t->uuid, serial_str, sizeof(t->uuid));
    } else {
            t->serial_number = smbios_add_prop(t->eos, node, "serial");
    }

•   t->sku_number = smbios_add_prop(t->eos, node, "sku");
  

•   t->family = smbios_add_prop(t->eos, node, "family");
  

t->family = smbios_add_prop_default(t->eos, node, "family", CONFIG_SYS_CPU)?

    len = t->length + smbios_string_table_len(t->eos);
    *current += len;

@@ -199,6 +202,7 @@ static int smbios_write_type2(ulong *current, int handle, ofnode node) CONFIG_SMBIOS_MANUFACTURER); t->product_name = smbios_add_prop_default(t->eos, node, "product", CONFIG_SMBIOS_PRODUCT_NAME);

•   t->asset_tag_number = smbios_add_prop(t->eos, node, "asset-tag");
    t->feature_flags = SMBIOS_BOARD_FEATURE_HOSTING;
    t->board_type = SMBIOS_BOARD_MOTHERBOARD;
  
  

--

Regards, Bin