-----Original Message----- From: Phillips Kim-R1AAHA Sent: Thursday, October 29, 2009 1:36 AM To: Kumar Gopalpet-B05799 Cc: u-boot@lists.denx.de Subject: Re: [PATCH v3 1/2] NET: Move MDIO regs out of TSEC Space
On Wed, 28 Oct 2009 14:19:18 +0530 Sandeep Gopalpet sandeep.kumar@freescale.com wrote:
Moved the mdio regs out of the tsec structure,and provided different offsets for tsec base and mdio base so that provision for
etsec2.0 can
be provided.
This patch helps in providing the support for etsec2.0 In etsec2.0, the MDIO register space and the etsec reg space are different.
Also, moved the TSEC_BASE_ADDR and MDIO_BASE_ADDR definitons into platform specific files.
Signed-off-by: Sandeep Gopalpet sandeep.kumar@freescale.com
without this patchseries:
U-Boot 2009.11-rc1 (Oct 28 2009 - 14:57:54) MPC83XX
Reset Status: Software Hard, External/Internal Soft, External/Internal Hard
CPU: e300c3, MPC8315E, Rev: 1.0 at 400 MHz, CSB: 133.333 MHz Board: Freescale MPC8315ERDB Rev 0.1 I2C: ready DRAM: 128 MB FLASH: 8 MB NAND: 32 MiB PCIE0: No link PCIE1: No link In: serial Out: serial Err: serial Net: eTSEC0, eTSEC1 Hit any key to stop autoboot: 0 => ping $serverip Speed: 1000, full duplex Using eTSEC0 device host 192.168.1.1 is alive =>
with this patchseries:
U-Boot 2009.11-rc1-00002-g3775d27 (Oct 28 2009 - 14:45:51) MPC83XX
Reset Status: Software Hard, External/Internal Soft, External/Internal Hard
CPU: e300c3, MPC8315E, Rev: 1.0 at 400 MHz, CSB: 133.333 MHz Board: Freescale MPC8315ERDB Rev 0.1 I2C: ready DRAM: 128 MB FLASH: 8 MB NAND: 32 MiB PCIE0: No link PCIE1: No link In: serial Out: serial Err: serial Net: eTSEC0: No support for PHY id 0; assuming generic eTSEC1: No support for PHY id 0; assuming generic eTSEC0, eTSEC1 Hit any key to stop autoboot: 0 => ping $serverip eTSEC0: No link. eTSEC1: No link. ping failed; host 192.168.1.1 is not alive
do you not test older version tsecs/83xx?
+typedef struct tsec_mdio +{
please also move this brace onto the above line.
Yes, Kim I have tested on one of the 83xx platforms. Will recheck if I missed something.
-Thanks Sandeep