Re: [PATCH v3] ddr: marvell: a38x: Add support for DDR4 from Marvell mv-ddr-marvell repository

Hi Pali,

On Thu, Jan 26, 2023 at 1:26 AM Stefan Roese sr@denx.de wrote:

On 1/19/23 04:03, Tony Dinh wrote:

...

This syncs drivers/ddr/marvell/a38x/ with the master branch of repository https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell.git

up to the commit "mv_ddr: a3700: Use the right size for memset to not overflow" d5acc10c287e40cc2feeb28710b92e45c93c702c

This patch was created by following steps:

  1. Replace all a38x files in U-Boot tree by files from upstream github
  Marvell mv-ddr-marvell repository.

  2. Run following command to omit portions not relevant for a38x, ddr3, and ddr4:

  files=drivers/ddr/marvell/a38x/*
  unifdef -m -UMV_DDR -UMV_DDR_ATF -UCONFIG_APN806 \
          -UCONFIG_MC_STATIC -UCONFIG_MC_STATIC_PRINT -UCONFIG_PHY_STATIC \
          -UCONFIG_PHY_STATIC_PRINT -UCONFIG_CUSTOMER_BOARD_SUPPORT \
          -UCONFIG_A3700 -UA3900 -UA80X0 -UA70X0 -DCONFIG_ARMADA_38X -UCONFIG_ARMADA_39X \
          -UCONFIG_64BIT $files

  3. Manually change license to SPDX-License-Identifier
  (upstream license in  upstream github repository contains long license
  texts and U-Boot is using just SPDX-License-Identifier.

After applying this patch, a38x, ddr3, and ddr4 code in upstream Marvell github repository and in U-Boot would be fully identical. So in future applying above steps could be used to sync code again.

The only change in this patch are: 1. Some fixes with include files. 2. Some function return and basic type defines changes in mv_ddr_plat.c (to correct Marvell bug). 3. Remove of dead code in newly copied files (as a result of the filter script stripping out everything other than a38x, dd3, and ddr4).

Reference: "ddr: marvell: a38x: Sync code with Marvell mv-ddr-marvell repository" https://source.denx.de/u-boot/u-boot/-/commit/107c3391b95bcc2ba09a876da4fa0c...

Signed-off-by: Tony Dinh mibodhi@gmail.com

Applied to u-boot-marvell/master

Thanks, Stefan

Looking at the history of the work we've done to sync u-boot code back to the mv-ddr-marvell repo, I think I should follow the same approach. So I've pushed 2 commits to my GitHub repo. https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/compare/master.....

Please review these 2 commits and create a pull request to Marvell, like you did for others last year during DDR3 code sync.

Thanks, Tony