Le 19/04/2013 10:15, Stefano Babic a écrit :
int checkboard(void) {
- puts("Board: MX6Q-SabreSD\n");
+#ifdef CONFIG_MX6Q
- puts("Board: MX6Q-SabreSD\n");
+#else
- puts("Board: MX6DL-SabreSD\n");
+#endif
Can we please avoid such #ifdef's? Here, we could for example refer to the board name (CONFIG_SYS_BOARD if you like the name, or some custom defined CONFIG_BOARD_NAME like other boards do).
And who does set CONFIG_MX6Q ? You drop it, but I do not see who sets it.
It is set in boards.cfg:
-mx6qsabresd arm armv7 mx6qsabresd freescale mx6 mx6qsabresd:IMX_CONFIG=board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg +mx6qsabresd arm armv7 mx6sabresd freescale mx6 mx6sabresd:IMX_CONFIG=board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg,MX6Q
Best regards, Stefano Babic
Best regards Pierre Aubert