Re: [PATCH 01/22] clk: check hw and hw->dev before dereference it

Hi Claudiu,

On Wed, 29 Jul 2020 at 08:51, Claudiu Beznea claudiu.beznea@microchip.com wrote:

Check hw and hw->dev before dereference it.

Signed-off-by: Claudiu Beznea claudiu.beznea@microchip.com

drivers/clk/clk.c | 3 +++ 1 file changed, 3 insertions(+)

Why is this needed? It adds to code size and these situations should not occur. Perhaps use assert()?

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 0f55ba751c0f..9fa18e342eaf 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -57,6 +57,9 @@ ulong clk_generic_get_rate(struct clk *clk)

const char *clk_hw_get_name(const struct clk *hw) {

•   if (!hw || !hw->dev)
  

•           return NULL;
  

•   return hw->dev->name;
  

}

-- 2.7.4

Regards, SImon