Hi Masahiro,
On 08/06/2014 11:48 AM, Masahiro Yamada wrote:
Hi Michal,
On Wed, 6 Aug 2014 11:10:14 +0200 Michal Simek michal.simek@xilinx.com wrote:
Based on steps below - defconfigs are both empty. Linux kernel is taking .config from /boot/config-`uname -r`.
Yes, but the .config of U-Boot is not installed anywhere in the host PC. I guess that is why DEFCONFIG_LIST seems meaningless...
I have to admit I am still searching for the usage of this option.
ok. great..
Maybe I do something wrong and Kconfig handles it differently but currently I can't see a reason to have this option there.
I don't think you did anything wrong.
[u-boot]$ make mrproper [u-boot]$ make savedefconfig HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o SHIPPED scripts/kconfig/zconf.tab.c SHIPPED scripts/kconfig/zconf.lex.c SHIPPED scripts/kconfig/zconf.hash.c HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf scripts/kconfig/conf --savedefconfig=defconfig Kconfig # # using defaults found in configs/sandbox_defconfig # [u-boot]$ cat defconfig
In this case, savedefconfig was done based on configs/sandbox_defconfig which is empty for now, but which will have more options in the future.
No problem with that. The question and my concern is that every .config will contain this line and this is just one usage which is questionable. IMHO if there is no .config savedefconfig should failed to let user to know that something is wrong. But that's just my opinion.
[u-boot]$ vim Kconfig [u-boot]$ git diff diff --git a/Kconfig b/Kconfig index 9e77a6e28b46..1a3864557df4 100644 --- a/Kconfig +++ b/Kconfig @@ -12,12 +12,6 @@ config KCONFIG_OBJDIR string option env="KCONFIG_OBJDIR"
-config DEFCONFIG_LIST
stringdepends on !SPL_BUILDoption defconfig_listdefault "configs/sandbox_defconfig"menu "General setup"
config SPL_BUILD [u-boot]$ make mrproper CLEAN scripts/basic CLEAN scripts/kconfig [u-boot]$ make savedefconfig HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o SHIPPED scripts/kconfig/zconf.tab.c SHIPPED scripts/kconfig/zconf.lex.c SHIPPED scripts/kconfig/zconf.hash.c HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf scripts/kconfig/conf --savedefconfig=defconfig Kconfig [u-boot]$ cat defconfig [u-boot]$
Whereas, this case, savedefconfig failed, that is why the file is empty.
It doesn't look at it is failing - just don't use that default one.
[u-boot]$ make mrproper CLEAN scripts/basic CLEAN scripts/kconfig [u-boot]$ git diff diff --git a/Kconfig b/Kconfig index 9e77a6e28b46..1a3864557df4 100644 --- a/Kconfig +++ b/Kconfig @@ -12,12 +12,6 @@ config KCONFIG_OBJDIR string option env="KCONFIG_OBJDIR"
-config DEFCONFIG_LIST - string - depends on !SPL_BUILD - option defconfig_list - default "configs/sandbox_defconfig" - menu "General setup"
config SPL_BUILD [u-boot]$ make savedefconfig HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o SHIPPED scripts/kconfig/zconf.tab.c SHIPPED scripts/kconfig/zconf.lex.c SHIPPED scripts/kconfig/zconf.hash.c HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf scripts/kconfig/conf --savedefconfig=defconfig Kconfig [u-boot]$ echo $? 0 [u-boot]$
Thanks, Michal