Re: [U-Boot] [PATCH] fsl-diu: Using I/O accessor to CCSR space

...

@@ -369,8 +370,8 @@ static int fsl_diu_enable_panel(struct

fb_info *info)

...

struct diu_ad *ad = &fsl_diu_fb_ad;

debug("Entered: enable_panel\n");

• if (hw->desc[0] != (unsigned int)ad)

• hw->desc[0] = (unsigned int)ad;
  

• if (in_be32(&hw->desc[0]) != (unsigned int)ad)

• out_be32(&hw->desc[0], ad);
  

'ad' should be cast to a u32, not an "unsigned int". You shouldn't compare a sized type with an unsized type.

Grep the include/asm-ppc/types.h, I got typedef unsigned int u32; The u32 is same as "unsigned int".

Kumar, any comments?