Re: [U-Boot-Users] [PATCH 04/17] i386: Fix global_data declaration

In message 1211130599-28289-5-git-send-email-plagnioj@jcrosoft.com you wrote:

Fix a warning type in lib_i386/board.c

Um... you not only fix a warning; you change the code pretty heavily.

--- a/lib_i386/board.c +++ b/lib_i386/board.c @@ -38,6 +38,9 @@ #include <ide.h> #include <asm/u-boot-i386.h>

+gd_t gd_data; +gd_t *gd;

Please do not name this 'gd_data'; stick with the 'global_data' name.

Also be aware that this is dangerous - this way it ends up in the BSS segment which most probably is uninitialized when you acess this data, and gets overwritten with zeroes some time later.

Is this really working code?

Best regards,

Wolfgang Denk