On Fri, 28 Jul 2023 at 07:52, Simon Glass sjg@google.com wrote:
Hi Maxim,
On Fri, 14 Jul 2023 at 08:22, Maxim Uvarov maxim.uvarov@linaro.org wrote:
changelog: v4: - tested with tests/py/ did some minor fixes (out of tree build, variables set after downloads). - accounted review comments for documentation. - implemented dns command - corrected wget command to not use serverip variable and
use just
url string. v3: - use lwip commands for ping,tftp,wget,dhcp if this patch applied. Drop CONFIG_LIB_LWIP_REPLACE_<COMMAND> option. - docs: use rst variant and drop references to RFC.build: git submodule init git submodule update make
I tested with qemu and ubuntu host for the server manually and with ./test/py/test -bd qemu_arm64 --build -k net.
If we are moving to a new stack we should take this oppty to create unit tests that deal with error paths as well, as it done in test/dm/eth.c
lwip itself has unit tests: https://git.savannah.nongnu.org/cgit/lwip.git/tree/test
I first time look on what is test/dm/eth.c but to compare it to for example https://git.savannah.nongnu.org/cgit/lwip.git/tree/test/unit/dhcp/test_dhcp.... it's about the same.
BR, Maxim.
What unit tests does lwip have?
Regards, Simon