On Wed, Feb 13, 2013 at 4:07 PM, Adnan Ali adnan.ali@codethink.co.uk wrote:
This commit introduces btrfs file-system to read file
I think we all know this is a commit ;-) so please start with:
Introduces btrfs file-system ...
from volume/sub-volumes with btrload command. This implementation has read-only support. This btrfs implementation is based on syslinux btrfs code.
I'd prefer the commit log to be split in 80 cols, as code. But this is my personal taste, dunno what others think.
Makefile | 3 +- common/Makefile | 1 + common/cmd_btr.c | 52 +++ fs/btrfs/Makefile | 51 +++ fs/btrfs/btrfs.c | 1131 +++++++++++++++++++++++++++++++++++++++++++++++++++++ fs/fs.c | 117 +++++- include/btrfs.h | 398 +++++++++++++++++++ include/crc32c.h | 48 +++ include/fs.h | 1 + 9 files changed, 1782 insertions(+), 20 deletions(-) create mode 100644 common/cmd_btr.c create mode 100644 fs/btrfs/Makefile create mode 100644 fs/btrfs/btrfs.c create mode 100644 include/btrfs.h create mode 100644 include/crc32c.h
diff --git a/Makefile b/Makefile index 3305e8c..8d2855a 100644 --- a/Makefile +++ b/Makefile @@ -270,7 +270,8 @@ LIBS-y += fs/libfs.o \ fs/reiserfs/libreiserfs.o \ fs/ubifs/libubifs.o \ fs/yaffs2/libyaffs2.o \
fs/zfs/libzfs.o
fs/zfs/libzfs.o\
Missed space after .o
fs/btrfs/libbtrfs.oLIBS-y += net/libnet.o LIBS-y += disk/libdisk.o LIBS-y += drivers/bios_emulator/libatibiosemu.o diff --git a/common/Makefile b/common/Makefile index 54fcc81..4abf26b 100644 --- a/common/Makefile +++ b/common/Makefile @@ -96,6 +96,7 @@ COBJS-$(CONFIG_SYS_HUSH_PARSER) += cmd_exit.o COBJS-$(CONFIG_CMD_EXT4) += cmd_ext4.o COBJS-$(CONFIG_CMD_EXT2) += cmd_ext2.o COBJS-$(CONFIG_CMD_FAT) += cmd_fat.o +COBJS-$(CONFIG_CMD_FAT) += cmd_btr.o
Something wrong here, no?!?! ;-) FAT?!?
I did not test the code yet but it'd be nice if you could fix those and resend. Did you pass the patch in checkpatch.pl script? I think it has some code styles issues as well but I didn't check it myself. Please do when preparing v2.
Please give a look at http://www.denx.de/wiki/U-Boot/Patches I think it is proper documented there.
-- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br