+cc a few people that had some input on that discussion. Apologies from top posting, but I am sending this from a mobile.
I think I've spent enough time trying to explain why I think we don't need to revert this and why moving the signature to the dtb once we fix it has minimal effect on the users.
Note that the mkeficapsule is completely irrelevant and shouldnt be reversed anyway but since we have to make changes in documentation etc and we are close to a release, just keep it in there.
If everyone is convinced that this needs to be reverted I am fine. I'll just refix all of the platforms(since with this reverted only qemu supports authenticated capsules) and have a look on the dtb issues.
Regards Ilias
On Sat, 18 Sep 2021, 14:34 Simon Glass, sjg@chromium.org wrote:
Hi Tom,
This is a revert of the EFI patches as mentioned on the mailing list. I believe this is the best way forward and avoids the current, flawed approach from getting into an official release and making it difficult to back out.
https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/9154
The following changes since commit d0b8c9a231d6e5fba881960c9fcfcc444f1812f9:
Merge branch '2021-09-17-TI-platform-updates' (2021-09-17 18:51:57 -0400)
are available in the Git repository at:
git@source.denx.de:u-boot/custodians/u-boot-dm.git tags/dm-pull-18sep21
for you to fetch changes up to 47a25e81d35c8d801cae9089de90c9ffea083409:
Revert "efi_capsule: Move signature from DTB to .rodata" (2021-09-18 03:47:50 -0600)
Revert the public-key-embedded-in-executable patches so this does not form part of an official release before it is agreed.
Simon Glass (3): Revert "doc: Update CapsuleUpdate READMEs" Revert "mkeficapsule: Remove dtb related options" Revert "efi_capsule: Move signature from DTB to .rodata"
board/emulation/common/Makefile | 1 + doc/develop/uefi/uefi.rst | 124 ------------------------------ include/asm-generic/sections.h | 2 - lib/efi_loader/Kconfig | 7 -- lib/efi_loader/Makefile | 8 -- lib/efi_loader/efi_capsule.c | 18 +---- lib/efi_loader/efi_capsule_key.S | 17 ----- tools/mkeficapsule.c | 229 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-- 8 files changed, 226 insertions(+), 180 deletions(-) delete mode 100644 lib/efi_loader/efi_capsule_key.S
Regards, Simon