Hi Stephen,
On 11 August 2015 at 08:55, Stephen Warren swarren@wwwdotorg.org wrote:
The existing FAT filesystem implementation in U-Boot has some bugs that are tricky to fix cleanly without significant rework of the code. For example, see:
http://lists.denx.de/pipermail/u-boot/2015-July/221054.html [PATCH] fat: handle paths that include ../
This series replaces U-Boot's FAT filesystem implementation with the "ff" project; http://elm-chan.org/fsw/ff/00index_e.html. This project appears to be actively maintained, does not have at least the bug referenced in the patch link above, and is quite easy to integrate into U-Boot. An earlier version is also used in Barebox, so presumably it's had some level of testing/exposure there.
This seems like a good idea to me. Are there some standard tests for FAT that we can bring in also? Perhaps using sandbox? At present we have fs-test.sh which is a start.
Note that this series is based on u-boot/master without the patch linked above applied. I wonder if it's a little risky to apply this series after -rc1; perhaps the patch above should be applied to v2015.10, and this series immediately after the release?
Sounds good.
Regards, Simon