
On 12/06/2011 11:53 AM, Simon Schwarz wrote:
On 12/06/2011 06:18 PM, Stefano Babic wrote:
I found the readon of the kernel corrupt image. We are setting a very hard address in /nand_spl_simple.c:
ecc_calc = (u_char *)(CONFIG_SYS_SDRAM_BASE + 0x10000);
Because the image for a TI SOC is loaded at 0x80008000, we have a conflict and the image is corrupted where the ECC is computed.
It is not a really good idea to fix in this way where to compute the ECC. Should be not better to put it in the CONFIG_SYS_INIT_RAM_ADDR area ?
There's a patch to fix this (with some minor changes requested): http://patchwork.ozlabs.org/patch/128018/
Best regards, Stefano Babic
Hmm. This is from the former nand_spl.
Why not use malloc for this? Thanks to changes in the FAT driver we now have it in the SPL.
I don't see a reason to have this in SRAM when SDRAM is available.
nand_spl_simple.c is used by some very small SPL targets -- 4K or so. malloc doesn't fit.
-Scott