Hi Graeme,
On Wed, Feb 15, 2012 at 6:28 PM, Graeme Russ graeme.russ@gmail.com wrote:
Hi Simon,
On Thu, Feb 16, 2012 at 1:05 PM, Simon Glass sjg@chromium.org wrote:
Hi,
On Mon, Jan 16, 2012 at 10:03 PM, Simon Glass sjg@chromium.org wrote:
Hi,
On Fri, Jan 6, 2012 at 4:24 PM, Simon Glass sjg@chromium.org wrote:
This series creates a generic board.c implementation which contains the essential functions of the major arch/xxx/lib/board.c files.
I haven't had huge numbers of comments on this series, but there are a few. I plan to tidy these up and resubmit, dropping the RFC tag, sometime this week.
Any patches / fixes to make this run properly on x86 / PPC would be gratefully accepted.
An update - Graeme asked me to wait until the x86 refactor is pulled - still waiting for that. Hopefully soon.
Pull request was sent a while ago and assigned to Wolfgang
http://patchwork.ozlabs.org/patch/139891
Maybe Wolgang missed it or it is low on his priorities
arch/x86/cpu/cpu.c | 109 +++++-- arch/x86/cpu/interrupts.c | 2 +- arch/x86/cpu/start.S | 33 +-- arch/x86/cpu/start16.S | 57 +++- arch/x86/include/asm/global_data.h | 21 +- arch/x86/include/asm/init_helpers.h | 44 +++ arch/x86/include/asm/init_wrappers.h | 42 +++ arch/x86/include/asm/processor.h | 24 ++- arch/x86/include/asm/relocate.h | 33 +++ arch/x86/include/asm/string.h | 2 +- arch/x86/include/asm/u-boot-x86.h | 5 + arch/x86/lib/Makefile | 4 + arch/x86/lib/bios.S | 134 ++++++---- arch/x86/lib/board.c | 517 ++++++++++------------------------ arch/x86/lib/cmd_boot.c | 64 +++++ arch/x86/lib/init_helpers.c | 217 ++++++++++++++ arch/x86/lib/init_wrappers.c | 137 +++++++++ arch/x86/lib/realmode_switch.S | 61 +++-- arch/x86/lib/relocate.c | 91 ++++++ arch/x86/lib/string.c | 61 ++++ arch/x86/lib/zimage.c | 7 + 21 files changed, 1152 insertions(+), 513 deletions(-) create mode 100644 arch/x86/include/asm/init_helpers.h create mode 100644 arch/x86/include/asm/init_wrappers.h create mode 100644 arch/x86/include/asm/relocate.h create mode 100644 arch/x86/lib/cmd_boot.c create mode 100644 arch/x86/lib/init_helpers.c create mode 100644 arch/x86/lib/init_wrappers.c create mode 100644 arch/x86/lib/relocate.c
As you can see, no changes outside x86, so a merge of u-boot-x86/master for building your new series should be safe
OK that's great, have pulled it in and rebased. Not sure why I missed it. Wolfgang are you going to pull this soon? I will make my generic board patch sit on top of it.
Regards, Simon
Regards,
Graeme