On 23:07 Sun 28 Jun , Grazvydas Ignotas wrote:
when you will be in possession of the old version of a board and just because few people have the board is remove from the mainline you will not be happy. So no we will support the both
Well old boards *do* actually work after these changes, except one game button and one analog controller (because of changed GPIOs). But all old boards don't have the analog controllers soldered to them, except one that I have (there were more but they were disassembled). Game buttons can't be used with old boards anyway because they don't fit into the case. So after considering these points I can say my "old boards are no longer supported" statement is not really valid.
What I read is
"no users ... ever got these boards"
I would bet that you have some early (broken?) alpha boards not being supported by U-Boot and never used because replaced by fixed revisions, too.
They will not have to be mainline until the hardware will be stablized
It's true, I sent initial patches before hardware was stabilized, but I thought it would be no problem sending patches like this later, after all hardware updates. Sorry if I was wrong.
you was not wrong, you just need to be carefull when you add new hardware revision support as the code was add for precedent hardware and you will need it to bisect it.
I've seen this kind of problem too much to not be carefull as you can have to pass hours maybe days to debug it
So now I'm going to split this patch and resend, is that ok with you?
as you confirm you do not brake the old hardware support just take a look to not loose the "game button" as the analog controller is not even availlable
otherwise fine
Best Regards, J.