Re: [U-Boot] [PATCH] mx53loco: Define CONFIG_BOARD_LATE_INIT

31 Jul 2012


      Am 31/07/2012 21:56, schrieb Wolfgang Denk:
...
Dear Fabio Estevam,
Hi Fabio,
...
In message CAOMZO5CBpA4kVC+J6Yp8RwmL-EbLwK1PcYWC_RLX=SwWRnqsyg@mail.gmail.com you wrote:
...
...
-#ifdef CONFIG_BOARD_LATE_INIT
 int board_late_init(void)
 {

setenv("stdout", "serial");


setenv("preboot", "setenv stdout serial\0");

NAK.  Please never, never ever mandatorily overwrite environment
variables!  The user who sets it to a different value and cannot find
out why his settings don;t work and always get overwritten would be
seriously frustrated.
Maybe a better way is to use CONFIG_PREBOOT as you do, but without
hard-coding the variable. You can add "preboot" to the default
environment (CONFIG_EXTRA_ENV_SETTINGS), and the user can still
overwrite the behavior setting the variable in the u-boot shell.
But I see I did not follow the same approach for the mx51evk (blame on
me !).
Stefano
-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@denx.de
=====================================================================

Re: [U-Boot] [PATCH] mx53loco: Define CONFIG_BOARD_LATE_INIT

stefano babic