Re: [U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

Dear Remy Bohmer,

In message AANLkTi=gnFZr6wT-RJ6CLFEKuGGhhpJUDbj1VftAR9kX@mail.gmail.com you wrote:

...

...

...

+#define WARN INFO +#define ERROR INFO +#define DEBUG INFO

This switches DEBUG logging on by default. This is not wanted. Can you please change that?

...

No, it does not.

Well, I see with this patch much more debug logging then without it... Hmm, it seems that you replaced all use of dprintf (which is trashed) by DEBUG()...

...

Anyway I can change it.

please do, DEBUG logging should not be on by default...

DEBUG is already a well-defined name. Any different use of the same name will result in the patches being rejected.

Please fix this!

I also object against names like WARN, ERROR and INFO. They are just too dangerous.

Best regards,

Wolfgang Denk