Re: [PATCH v3 4/5] dm: button: add support for linux_code in button-gpio.c driver

On Sun, 22 Jan 2023 at 08:22, Dzmitry Sankouski dsankouski@gmail.com wrote:

Linux event code must be used in input devices, using buttons.

Signed-off-by: Dzmitry Sankouski dsankouski@gmail.com

Changes for v2:

• fail, if linux,code not found

Changes for v3:

• add test for linux,code
• change linux,code type to int
• new line after return
• add specific error code in function docs

arch/sandbox/dts/test.dts | 2 ++ drivers/button/button-gpio.c | 17 ++++++++++++++++- drivers/button/button-uclass.c | 10 ++++++++++ include/button.h | 16 ++++++++++++++++ test/dm/button.c | 13 +++++++++++++ 5 files changed, 57 insertions(+), 1 deletion(-)

Reviewed-by: Simon Glass sjg@chromium.org