On 10/4/23 18:41, Paul Barker wrote:
On Wed, Oct 04, 2023 at 05:19:43PM +0200, Marek Vasut wrote:
On 10/4/23 15:48, Paul Barker wrote:
On Wed, Oct 04, 2023 at 02:27:50PM +0200, Marek Vasut wrote:
On 10/4/23 10:57, Paul Barker wrote:
On 03/10/2023 14:27, Marek Vasut wrote:
On 9/20/23 14:42, Paul Barker wrote: > We don't want to rely on source files including <asm/types.h> before > <asm/arch/rmobile.h>.
What kind of error does this solve ?
Without this, <asm/types.h> must be included before <asm/arch/rmobile.h>, for example in include/configs/rzg2l-smarc.h added in patch 16, to avoid the following error:
CC arch/arm/lib/asm-offsets.sIn file included from include/configs/rzg2l-smarc.h:9, from include/config.h:3, from include/common.h:16, from lib/asm-offsets.c:14: ./arch/arm/include/asm/arch/rmobile.h:49:7: error: unknown type name ‘u8’ 49 | const u8 *rzg_get_cpu_name(void);
Hmmm, that's weird, why am I not hitting it with the rcar CPU name function too ?
arch/arm/mach-rmobile/include/mach/rcar-gen3-base.h includes <asm/types.h> as it uses the `u32` type.
However, arch/arm/mach-rmobile/include/mach/rzg2l.h doesn't use anything from <asm/types.h> so doesn't include it.
Shouldn't arch/arm/mach-rmobile/include/mach/rmobile.h include the types.h then ?
That's what this patch adds.
Then this patch is
Reviewed-by: Marek Vasut marek.vasut+renesas@mailbox.org
Sorry for the noise.