On 14/03/2013 21:24, Wolfgang Denk wrote:
Dear Fabio,
Hi Wolfgang, hi Fabio,
Can we please remove the "Reset cause: WDOG" line in production mode?
Do you mean the change below?
--- a/arch/arm/imx-common/cpu.c +++ b/arch/arm/imx-common/cpu.c @@ -148,7 +148,7 @@ int print_cpuinfo(void) (cpurev & 0x000F0) >> 4, (cpurev & 0x0000F) >> 0, mxc_get_clock(MXC_ARM_CLK) / 1000000);
printf("Reset cause: %s\n", get_reset_cause());
debug("Reset cause: %s\n", get_reset_cause()); return 0;} #endif
Since this is common code I can address it separately with other patch. Just let me know if this is OK.
Indeed this is common code, I see it now. So yes, if we change this, it should be done as separate patch. I think debug() makes a lot of sense here to reduce the output at boot time to a reasonable minimum, but then - is there another way for the user to inquire for this information. If not, should we add it to the bdinfo output?
Reset cause is a very important information - we can know if the processor gets a watchdog, or if a power on happened. The last one can address to hiddden issues with the power supply.
I understand that less redundant information is better, but this is very important info and it cannot be used only if DEBUG is set. IMHO we should let it as it is - it helps us when something bad happens.
Best regards, Stefano Babic